feat(updater): allow to skip secrets sync for branching - #2932
Closed
avallete wants to merge 4 commits into
Closed
Conversation
Pull Request Test Coverage Report for Build 12114823667Details
💛 - Coveralls |
avallete
force-pushed
the
fix/skip-auth-secrets-syncing
branch
from
November 29, 2024 15:54
c3a9f62 to
6a90beb
Compare
avallete
changed the title
avallete
marked this pull request as ready for review
November 29, 2024 15:56
sweatybridge
requested changes
Nov 29, 2024
avallete
force-pushed
the
fix/skip-auth-secrets-syncing
branch
from
November 29, 2024 17:44
676f3b4 to
189f294
Compare
sweatybridge
reviewed
Dec 7, 2024
| ) | ||
|
|
||
| func (a *auth) StripUpdateBodySecrets(body v1API.UpdateAuthConfigBody) v1API.UpdateAuthConfigBody { | ||
| body.SmtpPass = nil |
Contributor
There was a problem hiding this comment.
Unfortunately most of these secrets are required fields that we validate on api side when something like smtp is enabled. Setting them to nil would essentially block everyone from updating the whole config block.
An alternative is to let users opt out of those configs by turning the struct into pointers. Similar to #2954
Member
Author
There was a problem hiding this comment.
Indeed I tested with a deployed project, and in such case the update went through but at the "first deploy" if no password is setup already then it'll fail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
On branching side we'll be able to do:
What is the current behavior?
Please link any relevant issues here.
What is the new behavior?
Feel free to include screenshots if it includes visual changes.
Additional context
Add any other context or screenshots.